-
-
Notifications
You must be signed in to change notification settings - Fork 595
feat: Add Parse.nodeLogging
to fully log Parse.Object
#1594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: alpha
Are you sure you want to change the base?
Conversation
Thanks for opening this pull request!
|
Does this influence existing built-in log messages? If so, maybe this should be optional, because logging object attributes may expose sensitive data in the logs. |
Yes it does, that's why it defaults to |
Alright, maybe we can add a short warning note about that to the option JSdoc. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #1594 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 64 64
Lines 6238 6245 +7
Branches 1450 1467 +17
=========================================
+ Hits 6238 6245 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The symbols are scoped locally per object and doesn't influence existing built in logs @mtrezza This is ready for review |
I believe I was referring to when using the Parse SDK in Cloud Code, whether that will output additional logs to the requester, which may expose information about the object, for example in case of an error. |
The requester will never see this right? |
That depends on what the server sends to the requester in case of an error. I don't know whether there is currently an error handling anywhere in Parse Server that would cause the full object being returned to the requester. In any case, I think my question back then was referring to the log files on the server side. Sensitive information should also not be in the log files by default. Maybe that's good for development, so if it's off by default that should be fine. I would just add an extra warning note to the option's doc that this should not be enabled in production. Maybe log a warning as well. |
New Pull Request Checklist
Issue Description
Currently, when logging a Parse.Object in NodeJS, the only thing that is logged is
ParseObject { _objCount: 376, className: 'Person' }
, which more often than not isn't overly helpful.Related issue:
n/a
Approach
Adds
Parse.nodeLogging
which logs the object out to:TODOs before merging